Eliminate temp filename based race condition from qsieve_factor #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `qsieve_factor()` function uses a temporary file (with name `qs_inf->fname`) for internal operation. There were a few issues with this file: * The name is supposed to be random, yet a prior `srand()` call ensures that different threads will be using an identical "random" name. The ensuing race condition leads to crashes. * The pre-existence of another file with the same name is not verified. * The file is created in the current directory instead of some temporary space. Fix: resorting to standard temporary file approaches (`mkstemp` on POSIX and `GetTempFileName` on Windows).
|
Looks like a reasonable fix. @wbhart is there a reason why the quadratic sieve uses files in the first place instead of doing everything in memory? |
|
No, not really, apart from the fact that you don't know how much memory there is. Pari/GP used to use files and I just adopted the same technique. Bill Allombert subsequently switched it to using memory, which is defensible these days. |
|
Indeed, #708 mentions this. Anyway, I will merge this as soon as CI is working again. |
Closed
This was referenced Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
qsieve_factor()function uses a temporary file (with nameqs_inf->fname) for internal operation.There were a few issues with this file:
srand()call ensures that different threads will be using an identical "random" name. The ensuing race condition leads to crashes.Fix: resorting to standard temporary file approaches (
mkstempon POSIX andGetTempFileNameon Windows).