gui: support FD_GUI_MAX_PEER_CNT many peers
#7238
Open
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Measurements ⏳
|
When there are no peers and we try to add `FD_GUI_MAX_PEER_CNT` peers, `gui->gossip.peer_cnt` would previously be stuck at `FD_GUI_MAX_PEER_CNT-1` due to the saturating arithmetic. The effect is that ALL `FD_GUI_MAX_PEER_CNT` peers of the input `msg` would be _copied_ into the `peers` array, but the last peer would be effectively ignored since the `gui->gossip.peer_cnt` would not reflect its addition. The value of `gui->gossip.peer_cnt` is now allowed to go up to `FD_GUI_MAX_PEER_CNT`, so that all `FD_GUI_MAX_PEER_CNT` peers can be added when starting from zero peers. The testing and bail-out when `gui->gossip.peer_cnt` is the maximum is unnecessary, due to the removal logic which ensures that the peer count can never exceed the maximum.
intrigus-lgtm
force-pushed
the
intrigus/fix/gui-allow-max-peer-cnt
branch
from
8830672 to
5c3e4be
Compare
Performance Measurements ⏳
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no peers and we try to add
FD_GUI_MAX_PEER_CNTpeers,gui->gossip.peer_cntwould previously be stuck atFD_GUI_MAX_PEER_CNT-1due to the saturating arithmetic.The effect is that ALL
FD_GUI_MAX_PEER_CNTpeers of the inputmsgwould be copied into thepeersarray, but the last peer would be effectively ignored since thegui->gossip.peer_cntwould not reflect its addition.The value of
gui->gossip.peer_cntis now allowed to go up toFD_GUI_MAX_PEER_CNT, so that allFD_GUI_MAX_PEER_CNTpeers can be added when starting from zero peers.The testing and bail-out when
gui->gossip.peer_cntis the maximum is unnecessary, due to the removal logic which ensures that the peer count can never exceed the maximum.