gui: support FD_GUI_MAX_PEER_CNT many peers

When there are no peers and we try to add `FD_GUI_MAX_PEER_CNT` peers,
`gui->gossip.peer_cnt` would previously be stuck at `FD_GUI_MAX_PEER_CNT-1` due to
the saturating arithmetic.
The effect is that ALL `FD_GUI_MAX_PEER_CNT` peers of the input `msg` would be _copied_
into the `peers` array, but the last peer would be effectively ignored since the
`gui->gossip.peer_cnt` would not reflect its addition.

The value of `gui->gossip.peer_cnt` is now allowed to go up to `FD_GUI_MAX_PEER_CNT`,
so that all `FD_GUI_MAX_PEER_CNT` peers can be added when starting from zero peers.


The testing and bail-out when `gui->gossip.peer_cnt` is the maximum is unnecessary, due
to the removal logic which ensures that the peer count can never exceed the maximum.

Author: intrigus-lgtm

src/disco/gui/fd_gui.c

@@ -862,10 +862,10 @@ fd_gui_poll( fd_gui_t * gui, long now ) {
 static void
 fd_gui_handle_gossip_update( fd_gui_t *    gui,
                              uchar const * msg ) {
-  if( FD_UNLIKELY( gui->gossip.peer_cnt == FD_GUI_MAX_PEER_CNT ) ) {
-    FD_LOG_DEBUG(("gossip peer cnt exceeds 40200 %lu, ignoring additional entries", gui->gossip.peer_cnt ));
-    return;
-  }
+  /* `gui->gossip.peer_cnt` is guaranteed to be in [0, FD_GUI_MAX_PEER_CNT], because
+  `peer_cnt` is FD_TEST-ed to be less than or equal FD_GUI_MAX_PEER_CNT.
+  For every new peer that is added an existing peer will be removed or was still free.
+  And adding a new peer is done at most `peer_cnt` times. */
   ulong const * header = (ulong const *)fd_type_pun_const( msg );
   ulong peer_cnt = header[ 0 ];
 
@@ -933,7 +933,7 @@ fd_gui_handle_gossip_update( fd_gui_t *    gui,
         gui->gossip.peers[ gui->gossip.peer_cnt ].sockets[ j ].port = *(ushort const *)(data+i*(58UL+12UL*6UL)+58UL+j*6UL+4UL);
       }
 
-      gui->gossip.peer_cnt = fd_ulong_min( gui->gossip.peer_cnt+1UL, FD_GUI_MAX_PEER_CNT-1UL );
+      gui->gossip.peer_cnt++;
     } else {
       int peer_updated = gui->gossip.peers[ found_idx ].shred_version!=*(ushort const *)(data+i*(58UL+12UL*6UL)+40UL) ||
                          // gui->gossip.peers[ found_idx ].wallclock!=*(ulong const *)(data+i*(58UL+12UL*6UL)+32UL) ||
@@ -990,10 +990,8 @@ fd_gui_handle_gossip_update( fd_gui_t *    gui,
 static void
 fd_gui_handle_vote_account_update( fd_gui_t *    gui,
                                    uchar const * msg ) {
-  if( FD_UNLIKELY( gui->vote_account.vote_account_cnt==FD_GUI_MAX_PEER_CNT ) ) {
-    FD_LOG_DEBUG(("vote account cnt exceeds 40200 %lu, ignoring additional entries", gui->vote_account.vote_account_cnt ));
-    return;
-  }
+  /* See fd_gui_handle_gossip_update for why `gui->vote_account.vote_account_cnt`
+  is guaranteed to be in [0, FD_GUI_MAX_PEER_CNT]. */
   ulong const * header = (ulong const *)fd_type_pun_const( msg );
   ulong peer_cnt = header[ 0 ];
 
@@ -1051,7 +1049,7 @@ fd_gui_handle_vote_account_update( fd_gui_t *    gui,
       gui->vote_account.vote_accounts[ gui->vote_account.vote_account_cnt ].commission = *(data+i*112UL+96UL);
       gui->vote_account.vote_accounts[ gui->vote_account.vote_account_cnt ].delinquent = *(data+i*112UL+97UL);
 
-      gui->vote_account.vote_account_cnt = fd_ulong_min( gui->vote_account.vote_account_cnt+1UL, FD_GUI_MAX_PEER_CNT-1UL );
+      gui->vote_account.vote_account_cnt++;
     } else {
       int peer_updated =
         memcmp( gui->vote_account.vote_accounts[ found_idx ].pubkey->uc, data+i*112UL+32UL, 32UL ) ||