Upgrade to Firecracker v0.18.0. #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipsma
requested review from
kzys,
nmeyerhans,
samuelkarp,
mxpv,
xibz and
IRCody
mxpv
reviewed
Sep 24, 2019
Makefile
Outdated
| @@ -175,14 +180,14 @@ tools/firecracker-builder-stamp: tools/docker/Dockerfile.firecracker-builder | |||
| tools/docker | |||
| touch $@ | |||
|
|
|||
| $(FIRECRACKER_BIN) $(JAILER_BIN): $(FIRECRACKER_DIR)/Cargo.toml tools/firecracker-builder-stamp | |||
| $(FIRECRACKER_BIN) $(JAILER_BIN): $(FIRECRACKER_DIR)/Cargo.toml $(FIRECRACKER_DIR) tools/firecracker-builder-stamp | |||
There was a problem hiding this comment.
Do we need both $(FIRECRACKER_DIR)/Cargo.toml and $(FIRECRACKER_DIR) here ? As we pull submodule, Cargo.toml will be already there, so we can have just one dependency.
There was a problem hiding this comment.
No that has no effect right now, this is leftover from something else I was trying but didn't include here, will remove.
samuelkarp
reviewed
Sep 24, 2019
This consists of: * Upgrading to the new Go SDK version. * Using the new vsock interface with unix-domain socket backend on the host. Signed-off-by: Erik Sipsma <[email protected]>
samuelkarp
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consists of:
Signed-off-by: Erik Sipsma [email protected]
Closes #259
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.