Skip to content

Add Firecracker vsock client code #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sipsma opened this issue Sep 25, 2019 · 4 comments
Closed

Add Firecracker vsock client code #136

sipsma opened this issue Sep 25, 2019 · 4 comments
Labels
enhancement New feature or request firecracker-feature An issue related to support for a feature provided by Firecracker

Comments

@sipsma
Copy link
Contributor

sipsma commented Sep 25, 2019

The recent vsock changes in Firecracker v0.18.0 result in some additional requirements on top of the previously-used standard vsock interface (for which there are already 3rd party libraries), see their docs and this PR for example.

Given there is now Firecracker-specific logic to interfacing with vsock, it would make sense for the Go SDK to contain that code rather than have all consumers of the Go SDK be forced to reimplement it themselves.

@sipsma sipsma added enhancement New feature or request firecracker-feature An issue related to support for a feature provided by Firecracker labels Sep 25, 2019
@Zyqsempai
Copy link
Contributor

@sipsma Is this still actual for us? Can I work on this one?

@sipsma
Copy link
Contributor Author

sipsma commented Nov 7, 2019

@Zyqsempai this is still something we'd like to do, though I'd caution that it will require a lot of cross-repo changes/coordination (since we'd basically just be migrating pieces of this firecracker-containerd code to this repo: https://github.com/firecracker-microvm/firecracker-containerd/blob/master/internal/vm/vsock.go ) and I'd suspect the hardest part by far would just be finding a way to write a test for the code in this repo.

The problem with the testing part is that this can really only be verified with an integ test that creates a real VM with some custom process running on the inside that uses the VM-guest-side of the vsock client implementation. That's easy to do in firecracker-containerd because we already have an agent process running in the VM, but we don't really have anything (to my knowledge) setup in this firecracker-go-sdk repo to enable that sort of test. It'd require some thought/design and potentially changes to how the CI works in this repo.

Overall, my opinion is that this wouldn't be the best issue for an external contributor unfortunately. There's some other issues in this repo I can point you to if interested that might be more workable (such as this one).

@Zyqsempai
Copy link
Contributor

@sipsma Thank you for letting me know, after your explanation, I am more than agree with you, actually, I didn't thought it's such a global change, I will take a look into other issues, thank you!

@kzys
Copy link
Contributor

kzys commented Feb 9, 2022

Resolved by #380 finally!

@kzys kzys closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request firecracker-feature An issue related to support for a feature provided by Firecracker
Projects
None yet
Development

No branches or pull requests

3 participants