Skip to content

Generate runtime-config per integ test case #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sipsma opened this issue Oct 15, 2019 · 0 comments
Closed

Generate runtime-config per integ test case #291

sipsma opened this issue Oct 15, 2019 · 0 comments
Assignees
@sipsma
Labels
kind/enhancement New feature or request

Comments

@sipsma
Copy link
Contributor

sipsma commented Oct 15, 2019

As described in this PR, we currently just copy statically defined runtime config files into the integ test containers. This works but duplicates a lot of configuration and makes it harder to write integ tests that test different variations on a runtime config.

A better model would be to add some test helper functions that generate the runtime config files per-testcase.
@sipsma sipsma added the kind/enhancement New feature or request label Oct 15, 2019
@sipsma sipsma self-assigned this Oct 15, 2019
@sipsma sipsma mentioned this issue Oct 15, 2019
Merged
kzys added a commit to kzys/firecracker-containerd that referenced this issue Oct 16, 2019
@kzys
Create CNI-enabled firecracker-runtime.json on the fly
5fa964a 
As firecracker-microvm#291 suggested, this change adds a helper that modifies
firecracker-runtime.json.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@kzys kzys mentioned this issue Oct 16, 2019
Merged
kzys added a commit to kzys/firecracker-containerd that referenced this issue Oct 16, 2019
@kzys
Create CNI-enabled firecracker-runtime.json on the fly
0248ad3 
As firecracker-microvm#291 suggested, this change adds a helper that modifies
firecracker-runtime.json.

Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys added a commit to kzys/firecracker-containerd that referenced this issue Oct 17, 2019
@kzys
Create firecracker-runtime.json on the fly
193b303 
As firecracker-microvm#291 suggested, this change adds a helper that modifies
firecracker-runtime.json.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@kzys kzys closed this as completed Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sipsma sipsma

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kzys @sipsma