Create CNI-enabled firecracker-runtime.json on the fly #292
Conversation
kzys
force-pushed
the
config-on-the-fly
branch
from
5fa964a to
0248ad3
Compare
There was a problem hiding this comment.
Thanks as I was planning on picking this up myself after my current task. This looks good but I think we should just update all of the tests to use the generator and get rid of tools/docker/firecracker-runtime.json too; I don't see any need to split the effort up.
|
The biggest reason is the jailer PR which modifies tools/docker/firecracker-runtime.json and runtime/service_integ_test.go. |
It's worth check with @xibz as it seems like rebasing the jailer PR would require just adding a few lines to |
|
@sipsma - Yea, it is minor to rebase on top of this. |
|
@sipsma/@xibz Thanks. Let me have a different additional commit to completely remove the file. If it looks fine. I'm going squash the commit with the existing one. |
| @@ -5,7 +5,5 @@ | |||
| "root_drive": "/var/lib/firecracker-containerd/runtime/default-rootfs.img", | |||
There was a problem hiding this comment.
Since most customers wouldn't generate the configuration file on-the-fly, I'd like to keep this JSON file inside examples/.
As firecracker-microvm#291 suggested, this change adds a helper that modifies firecracker-runtime.json. Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
force-pushed
the
config-on-the-fly
branch
from
54876b2 to
193b303
Compare
…ependabot/go_modules/github.com/go-openapi/errors-0.19.9 Bump github.com/go-openapi/errors from 0.19.8 to 0.19.9
Issue #, if available:
#291 but I'd like to keep the issue open until we remove
tools/docker/firecracker-runtime.json.Description of changes:
As #291 suggested, this change adds a helper that modifies firecracker-runtime.json.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.