Only use runtime config w/ default network ifaces in one test. #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestAutomaticCNISupport is the only test which requires a runtime config that has a list of default network interfaces. This change results in that test being the only one to use such a runtime config, which allows other tests to optionally not use any network interfaces if required. Signed-off-by: Erik Sipsma <[email protected]>
sipsma
requested review from
kzys,
nmeyerhans,
samuelkarp,
mxpv,
xibz and
IRCody
kzys
approved these changes
Oct 15, 2019
fangn2
pushed a commit
to fangn2/firecracker-containerd
that referenced
this pull request
Mar 23, 2023
Add support for the MMDS configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestAutomaticCNISupport is the only test which requires a runtime config
that has a list of default network interfaces. This change results in
that test being the only one to use such a runtime config, which allows
other tests to optionally not use any network interfaces if required.
Signed-off-by: Erik Sipsma [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
In general, I think a better model will be for tests to just each generate this runtime config themselves instead of using a set of static ones copied into the docker image (using some helper methods). I created an issue for implementing this, but the change in this PR will unblock in the short-term some needed test updates in the jailer PR.