Skip to content

Fix #994 Remove unnecessary error for FCM #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Fix #994 Remove unnecessary error for FCM #999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion messaging/src/ios/messaging.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ void NotifyListenerSet(Listener* listener) {
FIREBASE_ASSERT_RETURN(RequestPermissionLastResult(), internal::IsInitialized());

if (RequestPermissionLastResult().status() == kFutureStatusPending) {
LogError("Status is pending. Return the pending future.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a LogDebug if we still need this for some reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I merged before seeing this comment. Do you think I should add LogDebug back?

I did a code search and it does not seems like we are logging anything when LastResult is pending.

return RequestPermissionLastResult();
}

Expand Down