Fix #994 Remove unnecessary error for FCM #999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to log and error when the API returns the existing future.
cynthiajoan
approved these changes
Jun 17, 2022
jonsimantov
reviewed
Jun 17, 2022
| @@ -180,7 +180,6 @@ void NotifyListenerSet(Listener* listener) { | |||
| FIREBASE_ASSERT_RETURN(RequestPermissionLastResult(), internal::IsInitialized()); | |||
|
|
|||
| if (RequestPermissionLastResult().status() == kFutureStatusPending) { | |||
| LogError("Status is pending. Return the pending future."); | |||
There was a problem hiding this comment.
Could be a LogDebug if we still need this for some reason.
There was a problem hiding this comment.
Ah, I merged before seeing this comment. Do you think I should add LogDebug back?
I did a code search and it does not seems like we are logging anything when LastResult is pending.
github-actions
bot
added
the
tests: in-progress
✅ Integration test succeeded!Requested by @chkuang-g on commit 5f23f71 |
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary error for FCM
Description
There is no need to log and error when the API returns the existing future.
Testing
Integration test workflow
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.