Skip to content

[Experimental] Increase Android Emulator Test timeout from 10 mins to 20 mins #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2022

Conversation

sunmou99
Copy link
Contributor

Description

For firestore testapp, each individual test runs in less than 1 second locally.
However, in GHA, the run times of the individual tests and some are taking 5-10 seconds EACH. This excessive runtime could easily add up to surpass the original 10 mins limit.
e.g. https://github.com/firebase/firebase-cpp-sdk/runs/5769606818?check_suite_focus=true


Testing

See comment below


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@sunmou99 sunmou99 added tests-requested: quick Trigger a quick set of integration tests. skip-release-notes Skip release notes check labels Mar 31, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 31, 2022
@github-actions
Copy link

github-actions bot commented Mar 31, 2022

Integration test with FLAKINESS (succeeded after retry)

Requested by @sunmou99 on commit d2e9058
Last updated: Mon Apr 4 11:27 PDT 2022
View integration test log & download artifacts

Failures Configs
auth [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT
database [TEST] [FLAKINESS] [Android] [1/2 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseDatabaseTest.TestInfoConnected

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Mar 31, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 31, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Apr 1, 2022
@sunmou99 sunmou99 requested review from dconeybe and cynthiajoan April 1, 2022 17:47
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 1, 2022
@sunmou99 sunmou99 enabled auto-merge (squash) April 1, 2022 18:25
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 1, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 1, 2022
@sunmou99 sunmou99 merged commit d2e9058 into main Apr 4, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Apr 4, 2022
@sunmou99 sunmou99 deleted the bugfix/firestore-emulator-timeout branch April 4, 2022 16:05
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 4, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 4, 2022
@firebase firebase locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants