Skip to content

[Experimental] Increase Android Emulator Test timeout from 10 mins to 20 mins #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2022
Merged

[Experimental] Increase Android Emulator Test timeout from 10 mins to 20 mins #879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c1d59f
Update GameLoopUITest.kt
sunmou99 Mar 31, 2022
19c58e2
Update integration_tests.yml
sunmou99 Mar 31, 2022
627889d
Update gameloopUITests.swift
sunmou99 Apr 1, 2022
ca6ae30
Update integration_tests.yml
sunmou99 Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ jobs:
npm install -g firebase-tools
firebase emulators:start --only firestore --project demo-example &
- name: Run Android integration tests on Emulator locally
timeout-minutes: 90
timeout-minutes: 120
if: steps.get-device-type.outputs.device_type == 'virtual'
run: |
python scripts/gha/test_simulator.py --testapp_dir testapps \
Expand Down Expand Up @@ -998,7 +998,7 @@ jobs:
npm install -g firebase-tools
firebase emulators:start --only firestore --project demo-example &
- name: Run iOS integration tests on Simulator locally
timeout-minutes: 90
timeout-minutes: 120
if: steps.get-device-type.outputs.device_type == 'virtual'
run: |
python scripts/gha/test_simulator.py --testapp_dir testapps \
Expand Down Expand Up @@ -1095,7 +1095,7 @@ jobs:
npm install -g firebase-tools
firebase emulators:start --only firestore --project demo-example &
- name: Run tvOS integration tests on Simulator locally
timeout-minutes: 60
timeout-minutes: 90
run: |
python scripts/gha/test_simulator.py --testapp_dir testapps \
--tvos_device "${{ matrix.tvos_device }}" \
Expand Down
2 changes: 1 addition & 1 deletion .../gameloop_android/app/src/androidTest/java/com/google/firebase/gameloop/GameLoopUITest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import org.junit.runner.RunWith
class GameLoopUITest {

companion object {
const val GAMELOOP_TIMEOUT = 10 * 60 * 1000L
const val GAMELOOP_TIMEOUT = 20 * 60 * 1000L
}

private lateinit var device: UiDevice
Expand Down
4 changes: 2 additions & 2 deletions scripts/gha/integration_testing/gameloop_apple/gameloopUITests/gameloopUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ class GameLoopLauncherUITests: XCTestCase {
{
return timeoutSecs
} else {
// Default 8 minutes
return TimeInterval(8 * 60)
// Default 15 minutes
return TimeInterval(15 * 60)
}
}
}