Skip to content

Feature/update brew version #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2021
Merged

Feature/update brew version #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c80a1c9
update homebrew version before installing packages.
vimanyu Apr 12, 2021
43099a7
update brew
vimanyu Apr 12, 2021
c15fee5
fixed bad workflow syntax
vimanyu Apr 12, 2021
15cd48b
Merge branch 'main' into feature/update-brew-version
vimanyu Apr 12, 2021
8bbd645
updating brew version in all other workflows.
vimanyu Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,14 @@ jobs:
path: /tmp/android-ndk-r16b
key: android-ndk-${{ matrix.os }}-r16b

- name: Update homebrew (avoid bintray errors)
if: startsWith(matrix.os, 'macos')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason this uses startsWith(matrix.os) and the below uses runner.os ==? Can you unify them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I was trying to keep it consistent with any other macos checks in those blocks.
For a couple of the blocks, I found the comparison used runner.os and for others, we used macos.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, cpp-packaging uses runner.os comparison,
c87c8a4

integration_tests.yml uses "matrix.os"
ce9c9fa

run: |
# Temporarily here until Github runners have updated their version of
# homebrew. This prevents errors arising from the shut down of
# binutils, used by older version of homebrew for hosting packages.
brew update

- name: Install prerequisites
shell: bash
run: |
Expand Down
16 changes: 16 additions & 0 deletions .github/workflows/cpp-packaging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,14 @@ jobs:
with:
python-version: ${{ matrix.python_version }}

- name: Update homebrew (avoid bintray errors)
if: runner.os == 'macOS'
run: |
# Temporarily here until Github runners have updated their version of
# homebrew. This prevents errors arising from the shut down of
# binutils, used by older version of homebrew for hosting packages.
brew update

- name: Install prerequisites
run: |
python scripts/gha/install_prereqs_desktop.py
Expand Down Expand Up @@ -432,6 +440,14 @@ jobs:
with:
python-version: 3.7

- name: Update homebrew (avoid bintray errors)
if: runner.os == 'macOS'
run: |
# Temporarily here until Github runners have updated their version of
# homebrew. This prevents errors arising from the shut down of
# binutils, used by older version of homebrew for hosting packages.
brew update

- name: Install prerequisites
run: |
cd sdk-src
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ jobs:
python-version: ${{ matrix.python_version }}
architecture: 'x64'

- name: Update homebrew (avoid bintray errors)
if: startsWith(matrix.os, 'macos')
run: |
# Temporarily here until Github runners have updated their version of
# homebrew. This prevents errors arising from the shut down of
# binutils, used by older version of homebrew for hosting packages.
brew update

- name: Install prerequisites
run: |
python scripts/gha/install_prereqs_desktop.py
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,14 @@ jobs:
with:
python-version: '3.7'

- name: Update homebrew (avoid bintray errors)
if: startsWith(matrix.os, 'macos')
run: |
# Temporarily here until Github runners have updated their version of
# homebrew. This prevents errors arising from the shut down of
# binutils, used by older version of homebrew for hosting packages.
brew update

- name: Install SDK Desktop prerequisites
if: matrix.target_platform == 'Desktop'
run: |
Expand Down