Feature/update brew version #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like bintray is shut down and the older versions of brew look for packages in bintray. Homebrew/discussions#691
jonsimantov
reviewed
Apr 12, 2021
jonsimantov
suggested changes
Apr 12, 2021
| @@ -78,6 +78,14 @@ jobs: | |||
| path: /tmp/android-ndk-r16b | |||
| key: android-ndk-${{ matrix.os }}-r16b | |||
|
|
|||
| - name: Update homebrew (avoid bintray errors) | |||
| if: startsWith(matrix.os, 'macos') | |||
There was a problem hiding this comment.
any particular reason this uses startsWith(matrix.os) and the below uses runner.os ==? Can you unify them?
There was a problem hiding this comment.
So I was trying to keep it consistent with any other macos checks in those blocks.
For a couple of the blocks, I found the comparison used runner.os and for others, we used macos.
|
Thanks for pointing it out. Yes, they needed this update too. |
jonsimantov
approved these changes
Apr 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for errors observed while installing packages with homebrew. Until Github runners are updated to use latest hombrew versions, manually updating homebrew in Github workflows.
Homebrew/brew#11070
Homebrew/discussions#691