Skip to content

Auto update GMA deps on iOS. #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Auto update GMA deps on iOS. #1191

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
555dad1
Update dependencies script.
jonsimantov Jan 24, 2023
2ccc7fe
Add code for ignoring old admob cppsdk versions.
jonsimantov Jan 24, 2023
79fea09
Merge branch 'main' into HEAD
jonsimantov Jan 24, 2023
94afaf0
Add comments
jonsimantov Jan 24, 2023
a9e9fa8
Add arg
jonsimantov Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions scripts/update_android_ios_dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,14 +316,16 @@ def get_pod_files(dirs_and_files):
RE_PODFILE_VERSION = re.compile(
r"\s+pod '(?P<pod_name>.+)', '(?P<version>.+)'\n")

def modify_pod_file(pod_file, pod_version_map, dryrun=True):
def modify_pod_file(pod_file, pod_version_map, dryrun=True, ignore_ios_versions=[]):
"""Update pod versions in specified podfile.

Args:
pod_file (str): Absolute path to a podfile.
pod_version_map (dict): Map of podnames to their respective version.
dryrun (bool, optional): Just print the substitutions.
Do not write to file. Defaults to True.
ignore_ios_versions (set): If the old version number for a pod
matches one of these, don't update it.
"""
global logfile_lines
to_update = False
Expand All @@ -341,9 +343,14 @@ def modify_pod_file(pod_file, pod_version_map, dryrun=True):
match = re.match(RE_PODFILE_VERSION, line)
if match:
pod_name = match['pod_name']
skip_line = False
# Check if the old version matches anything in ignore_ios_versions
for ignore_version in ignore_ios_versions:
if ignore_version in match['version']:
skip_line = True
# Firebase/Auth -> Firestore (due to being a subspec)
pod_name_key = re.sub(r'/.*$', '', pod_name)
if pod_name_key in pod_version_map:
if pod_name_key in pod_version_map and not skip_line:
latest_version = pod_version_map[pod_name_key]
substituted_line = line.replace(match['version'], latest_version)
if substituted_line != line:
Expand Down Expand Up @@ -690,10 +697,12 @@ def parse_cmdline_args():
parser.add_argument('--skip_ios', action='store_true',
help='Skip iOS pod version update completely.')
# TODO: remove default values when Ads SDK does not need to be pinned.
parser.add_argument('--ignore_ios_pods', nargs='+',
default=('Google-Mobile-Ads-SDK',),
parser.add_argument('--ignore_ios_pods', nargs='+', default=(),
help='Ignore iOS pods which have any of the items specified in '
'this list as substrings.')
parser.add_argument('--ignore_ios_versions', nargs='+', default=('cppsdk',),
help='Do not update any iOS pods when the old version contains '
'any of the items specified in this list as substrings.')
parser.add_argument('--podfiles', nargs='+', default=(os.getcwd(),),
help= 'List of pod files or directories containing podfiles')
parser.add_argument('--specs_repo',
Expand Down Expand Up @@ -755,7 +764,8 @@ def main():
pod_files = get_files(args.podfiles, file_extension='', file_name='Podfile',
ignore_directories=set(args.ignore_directories))
for pod_file in pod_files:
modify_pod_file(pod_file, latest_pod_versions_map, args.dryrun)
modify_pod_file(pod_file, latest_pod_versions_map, args.dryrun,
args.ignore_ios_versions)
for readme_file in readme_files:
modify_readme_file_pods(readme_file, latest_pod_versions_map, args.dryrun)

Expand Down