Skip to content

Auto update GMA deps on iOS. #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Auto update GMA deps on iOS. #1191

merged 5 commits into from
Jan 25, 2023

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jan 24, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

Requires some custom code to handle the old 'admob' iOS SDK.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Ran manually, it updated everything correctly and skipped the old admob SDK.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jan 24, 2023
@DellaBitta
Copy link
Contributor

Does this mean the older AdMob SDK will now be updated?

@jonsimantov
Copy link
Contributor Author

Does this mean the older AdMob SDK will now be updated?

No:

  1. You'll see I added a flag that makes it not update any iOS versions that contain "cppsdk"
  2. The old Android SDK uses firebase-ads, which is still in the "don't update" list.

@jonsimantov jonsimantov merged commit 7911900 into main Jan 25, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jan 25, 2023
@github-actions
Copy link

github-actions bot commented Jan 25, 2023

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 7911900
Last updated: Wed Jan 25 13:36 PST 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestRewardedAdLoadEmptyRequest
[TEST] [FLAKINESS] [Android] [2/3 os: ubuntu windows] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestRewardedAdLoad
[TEST] [FLAKINESS] [Android] [All 3 os] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestRewardedAdStress
messaging [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 25, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 25, 2023
@firebase firebase locked and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants