Skip to content

Change ubuntu usage from latest to 20.04 #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ concurrency:

jobs:
prepare_matrix:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
outputs:
matrix_os: ${{ steps.export-result.outputs.matrix_os }}
matrix_architecture: ${{ steps.export-result.outputs.matrix_architecture }}
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ concurrency:

jobs:
file_format_check:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -40,7 +40,7 @@ jobs:

check_integration_test_labels:
# This check fails if integration tests are queued, in progress, or failed.
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- uses: docker://agilepathway/pull-request-label-checker:latest
with:
Expand All @@ -49,7 +49,7 @@ jobs:

generated_docs_check:
# This check succeeds if Doxygen documentation generates without errors.
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:

copyright_check:
# Check for Google copyright in each file.
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -100,7 +100,7 @@ jobs:

release_notes_check:
# Check that the readme was updated, unless the PR has a specific label set (env.skipReleaseNotesLabel).
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
# Skip this if the PR has the skipReleaseNotes label or if it's a merge to other than main.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/checks_secure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ concurrency:
jobs:
dismiss_stale_approvals:
# Dismiss stale approvals for non-admins or if this PR comes from a fork.
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
# Only if another commit was added to the PR.
steps:
- name: Check user permission
Expand Down
46 changes: 23 additions & 23 deletions .github/workflows/cpp-packaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ env:
jobs:
log_inputs:
name: log-inputs
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- name: log run inputs
run: |
Expand Down Expand Up @@ -79,9 +79,9 @@ jobs:
if: ${{ github.event.inputs.downloadPublicVersion == '' && github.event.inputs.downloadPreviousRun == '' }}
strategy:
matrix:
os: [ubuntu-latest, macos-12]
os: [ubuntu-20.04, macos-12]
include:
- os: ubuntu-latest
- os: ubuntu-20.04
tools_platform: linux
# Binutils 2.35.1 released Sep 19, 2020
binutils_version: "2.35.1"
Expand Down Expand Up @@ -243,7 +243,7 @@ jobs:

build_and_package_android:
name: build-and-package-android
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
if: ${{ github.event.inputs.downloadPublicVersion == '' && github.event.inputs.downloadPreviousRun == '' }}
strategy:
fail-fast: false
Expand Down Expand Up @@ -305,7 +305,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-latest, ubuntu-latest, macos-12]
os: [windows-latest, ubuntu-20.04, macos-12]
build_type: ["Release", "Debug"]
architecture: ["x64", "x86", "arm64"]
msvc_runtime: ["static", "dynamic"]
Expand All @@ -321,7 +321,7 @@ jobs:
vcpkg_triplet_suffix: "windows-static-md"
additional_build_flags: "--build_tests"
sdk_platform: "windows"
- os: ubuntu-latest
- os: ubuntu-20.04
vcpkg_triplet_suffix: "linux"
additional_build_flags: ""
sdk_platform: "linux"
Expand All @@ -341,11 +341,11 @@ jobs:
linux_abi: "c++11"
- os: macos-12
build_type: "Debug"
- os: ubuntu-latest
- os: ubuntu-20.04
msvc_runtime: "dynamic"
- os: ubuntu-latest
- os: ubuntu-20.04
build_type: "Debug"
- os: ubuntu-latest
- os: ubuntu-20.04
architecture: "arm64"
- os: windows-latest
architecture: "arm64"
Expand Down Expand Up @@ -464,40 +464,40 @@ jobs:
matrix:
sdk_platform: [linux, darwin, windows]
suffix: ['']
runs_on_platform: [ubuntu-latest]
runs_on_platform: [ubuntu-20.04]
include:
# Split windows packaging into multiple runners.
- sdk_platform: windows
suffix: '-x86-Release-static'
runs_on_platform: ubuntu-latest
runs_on_platform: ubuntu-20.04
- sdk_platform: windows
suffix: '-x86-Release-dynamic'
runs_on_platform: ubuntu-latest
runs_on_platform: ubuntu-20.04
- sdk_platform: windows
suffix: '-x64-Release-static'
runs_on_platform: ubuntu-latest
runs_on_platform: ubuntu-20.04
- sdk_platform: windows
suffix: '-x64-Release-dynamic'
runs_on_platform: ubuntu-latest
runs_on_platform: ubuntu-20.04
- sdk_platform: windows
suffix: '-x86-Debug-static'
runs_on_platform: ubuntu-latest
runs_on_platform: ubuntu-20.04
- sdk_platform: windows
suffix: '-x86-Debug-dynamic'
runs_on_platform: ubuntu-latest
runs_on_platform: ubuntu-20.04
- sdk_platform: windows
suffix: '-x64-Debug-static'
runs_on_platform: ubuntu-latest
runs_on_platform: ubuntu-20.04
- sdk_platform: windows
suffix: '-x64-Debug-dynamic'
runs_on_platform: ubuntu-latest
runs_on_platform: ubuntu-20.04
- sdk_platform: darwin
runs_on_platform: macos-12
exclude:
- sdk_platform: windows
suffix: ''
- sdk_platform: darwin
runs_on_platform: ubuntu-latest
runs_on_platform: ubuntu-20.04
steps:
- name: setup Xcode version (macos)
if: runner.os == 'macOS'
Expand Down Expand Up @@ -649,7 +649,7 @@ jobs:

download_sdk_package:
name: download-sdk-package
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
needs: [log_inputs]
if: ${{ github.event.inputs.downloadPublicVersion != '' || github.event.inputs.downloadPreviousRun != '' }}
steps:
Expand Down Expand Up @@ -699,7 +699,7 @@ jobs:

merge_packages:
name: final-merge-packages
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
if: ${{ github.event.inputs.downloadPublicVersion == '' && github.event.inputs.downloadPreviousRun == '' }}
needs: [build_and_package_ios_tvos, build_and_package_android, package_desktop, log_inputs]
steps:
Expand Down Expand Up @@ -763,7 +763,7 @@ jobs:
# Clean up intermediate artifacts from packaging step.
# This can happen after the final package merge is finished.
name: cleanup-packaging-artifacts
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
needs: [merge_packages]
if: |
(
Expand All @@ -784,7 +784,7 @@ jobs:
# Trigger the integration_tests workflow.
needs: [merge_packages, download_sdk_package, cleanup_packaging_artifacts]
if: (github.event.inputs.skipIntegrationTests == 0 || github.event.inputs.skipIntegrationTests == '') && !cancelled() && !failure()
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- name: Checkout repo
uses: actions/checkout@v3
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ concurrency:

jobs:
prepare_matrix:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
outputs:
matrix_os: ${{ steps.export-result.outputs.matrix_os }}
matrix_build_type: ${{ steps.export-result.outputs.matrix_build_type }}
Expand Down Expand Up @@ -70,24 +70,24 @@ jobs:
msvc_runtime: "dynamic"
exclude:
# msvc_runtime excludes
- os: ubuntu-latest
- os: ubuntu-20.04
msvc_runtime: "dynamic"
- os: macos-12
msvc_runtime: "dynamic"
# architecture excluees
- os: macos-12
architecture: "x86"
# Xcode excludes -- allow only one on osx and linux
- os: ubuntu-latest
- os: ubuntu-20.04
xcode_version: "11.7"
- os: windows-latest
xcode_version: "11.7"
- os: ubuntu-latest
- os: ubuntu-20.04
xcode_version: "12.5.1"
- os: windows-latest
xcode_version: "12.5.1"
# arm64 is only for macos
- os: ubuntu-latest
- os: ubuntu-20.04
architecture: "arm64"
- os: windows-latest
architecture: "arm64"
Expand Down Expand Up @@ -292,7 +292,7 @@ jobs:
### It's possible to add more apps here once integration tests are less flaky.
name: local-integration-tests-linux-openssl
needs: prepare_matrix
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
strategy:
fail-fast: false
steps:
Expand Down Expand Up @@ -331,15 +331,15 @@ jobs:
python scripts/gha/build_testapps.py --p Desktop \
--t ${apis} \
--output_directory "${{ github.workspace }}" \
--artifact_name "desktop-ubuntu-latest-openssl" \
--artifact_name "desktop-ubuntu-20.04-openssl" \
--noadd_timestamp \
--short_output_paths \
--cmake_flag=-DFIREBASE_QUICK_TEST=ON
- name: Summarize build results
if: ${{ !cancelled() }}
shell: bash
run: |
cat build-results-desktop-ubuntu-latest-openssl.log
cat build-results-desktop-ubuntu-20.04-openssl.log
if [[ "${{ job.status }}" != "success" ]]; then
exit 1
fi
Expand All @@ -361,15 +361,15 @@ jobs:
java-version: '17'
- name: Run Desktop integration tests
run: |
cp scripts/gha/integration_testing/google-services.json testapps-desktop-ubuntu-latest-openssl/firestore/google-services.json
firebase emulators:exec --only firestore --project demo-example 'python scripts/gha/desktop_tester.py --testapp_dir testapps-desktop-ubuntu-latest-openssl --logfile_name "desktop-ubuntu-latest-openssl"'
cp scripts/gha/integration_testing/google-services.json testapps-desktop-ubuntu-20.04-openssl/firestore/google-services.json
firebase emulators:exec --only firestore --project demo-example 'python scripts/gha/desktop_tester.py --testapp_dir testapps-desktop-ubuntu-20.04-openssl --logfile_name "desktop-ubuntu-20.04-openssl"'
env:
USE_FIRESTORE_EMULATOR: true
- name: Summarize test results
if: ${{ !cancelled() }}
shell: bash
run: |
cat testapps-desktop-ubuntu-latest-openssl/test-results-desktop-ubuntu-latest-openssl.log
cat testapps-desktop-ubuntu-20.04-openssl/test-results-desktop-ubuntu-20.04-openssl.log
if [[ "${{ job.status }}" != "success" ]]; then
exit 1
fi
12 changes: 6 additions & 6 deletions .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
required: true
operating_systems:
description: 'CSV of VMs to run on'
default: 'ubuntu-latest,windows-latest,macos-12'
default: 'ubuntu-20.04,windows-latest,macos-12'
required: true
desktop_ssl_variants:
description: 'CSV of desktop SSL variants to use'
Expand Down Expand Up @@ -55,7 +55,7 @@ env:

jobs:
check_and_prepare:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
outputs:
trigger: ${{ steps.set_outputs.outputs.trigger }}
github_ref: ${{ steps.set_outputs.outputs.github_ref }}
Expand Down Expand Up @@ -250,7 +250,7 @@ jobs:
# Do not attempt to use arm64 on Windows or Linux.
- os: windows-latest
arch: arm64
- os: ubuntu-latest
- os: ubuntu-20.04
arch: arm64
# Do not attempt to use x86 on Mac.
- os: macos-12
Expand Down Expand Up @@ -698,7 +698,7 @@ jobs:
# Do not attempt to use arm64 on Windows or Linux.
- os: windows-latest
arch: arm64
- os: ubuntu-latest
- os: ubuntu-20.04
arch: arm64
# Do not attempt to use x86 on Mac.
- os: macos-12
Expand Down Expand Up @@ -817,7 +817,7 @@ jobs:
runner_label: ['${{ needs.check_and_prepare.outputs.runner_label_macos_arm64 }}']
exclude:
# Don't run Linux or Windows tests on the Mac arm64 runner.
- os: ubuntu-latest
- os: ubuntu-20.04
runner_label: ${{ needs.check_and_prepare.outputs.runner_label_macos_arm64 }}
- os: windows-latest
runner_label: ${{ needs.check_and_prepare.outputs.runner_label_macos_arm64 }}
Expand Down Expand Up @@ -1318,7 +1318,7 @@ jobs:
summarize_results:
name: "summarize-results"
needs: [check_and_prepare, test_desktop, test_desktop_custom_runners, test_android, test_ios, test_tvos]
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
if: ${{ !cancelled() }}
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ concurrency:

jobs:
prepare_matrix:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
outputs:
matrix_xcode_version: ${{ steps.export-result.outputs.matrix_xcode_version }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ concurrency:

jobs:
lint_warnings_check_and_comment:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reviewer-roulette.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ env:
jobs:
assign_random_reviewer:
if: github.event.action == 'labeled' && github.event.label.name == 'reviewer-roulette'
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- name: Unset label
uses: buildsville/add-remove-label@v1
Expand Down
Loading