Skip to content

Change ubuntu usage from latest to 20.04 #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Change ubuntu usage from latest to 20.04 #1157

merged 2 commits into from
Nov 29, 2022

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Nov 29, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Change the usage of GHA runners from ubuntu-latest to ubuntu-20.04.
The shift of GHA to point ubuntu-latest to `ubuntu-22.04' (citation) has caused issues


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Packaging CI -> Integration CI (GMA backoff flakes).


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@DellaBitta DellaBitta marked this pull request as ready for review November 29, 2022 00:43
@DellaBitta DellaBitta merged commit de396ba into main Nov 29, 2022
@DellaBitta DellaBitta deleted the ddb/unbuntu-2020 branch November 29, 2022 12:34
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Nov 29, 2022
@github-actions
Copy link

github-actions bot commented Nov 29, 2022

❌  Integration test FAILED

Requested by @DellaBitta on commit de396ba
Last updated: Tue Nov 29 07:53 PST 2022
View integration test log & download artifacts

Failures Configs
database [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  FirebaseDatabaseTest.TestInfoConnected
firestore [TEST] [ERROR] [Android] [2/3 os: macos ubuntu] [1/2 android_device: android_target]
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseGmaTest.TestRewardedAdLoadEmptyRequest
storage [TEST] [FLAKINESS] [Android] [2/3 os: macos ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Nov 29, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 29, 2022
@firebase firebase locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants