modify the typo in deform_source_mesh_to_target_mesh.ipynb #13
Conversation
|
Hi Robonchu! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Hi @Robonchu! Thank you so much for pointing out this typo in the tutorial. :) We really value users reporting issues so that we can make the tutorials smoother. We're collecting several of these issues and will make a collective update to the tutorials and docs soon. |
Summary: The multiplicative factors in function embeddings go from `2**0` to `2**(self.n_harmonic_functions-1)`, and not from `2**0` to `2**self.n_harmonic_functions`. Pull Request resolved: fairinternal/pytorch3d#13 Reviewed By: nikhilaravi Differential Revision: D28637894 Pulled By: ignacio-rocco fbshipit-source-id: da20f39eba9aaa09af5b24be1554a3bfd7556281
I modified the typo from
doplhintodolphinin thedeform_source_mesh_to_target_mesh.ipynbof the tutorial.