Skip to content

Commit 4efadae

Browse files
ignacio-roccofacebook-github-bot
authored andcommitted
Minor fix in HarmonicEmbedding docstring (#13)
Summary: The multiplicative factors in function embeddings go from `2**0` to `2**(self.n_harmonic_functions-1)`, and not from `2**0` to `2**self.n_harmonic_functions`. Pull Request resolved: fairinternal/pytorch3d#13 Reviewed By: nikhilaravi Differential Revision: D28637894 Pulled By: ignacio-rocco fbshipit-source-id: da20f39eba9aaa09af5b24be1554a3bfd7556281
1 parent ed6983e commit 4efadae

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/tutorials/fit_simple_neural_radiance_field.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,12 +257,12 @@
257257
" sin(2*x[..., i]),\n",
258258
" sin(4*x[..., i]),\n",
259259
" ...\n",
260-
" sin(2**self.n_harmonic_functions * x[..., i]),\n",
260+
" sin(2**(self.n_harmonic_functions-1) * x[..., i]),\n",
261261
" cos(x[..., i]),\n",
262262
" cos(2*x[..., i]),\n",
263263
" cos(4*x[..., i]),\n",
264264
" ...\n",
265-
" cos(2**self.n_harmonic_functions * x[..., i])\n",
265+
" cos(2**(self.n_harmonic_functions-1) * x[..., i])\n",
266266
" ]\n",
267267
" \n",
268268
" Note that `x` is also premultiplied by `omega0` before\n",

0 commit comments

Comments
 (0)