Skip to content

Conversation

poteto
Copy link
Member

@poteto poteto commented Oct 7, 2025

Allow running the compiler release script as dry run.

@meta-cla meta-cla bot added the CLA Signed label Oct 7, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Oct 7, 2025
@react-sizebot
Copy link

react-sizebot commented Oct 7, 2025

Comparing: a664f5f...450ad4d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 604.98 kB 604.98 kB = 107.14 kB 107.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.95 kB 663.95 kB = 117.03 kB 117.03 kB
facebook-www/ReactDOM-prod.classic.js = 687.81 kB 687.81 kB = 121.07 kB 121.07 kB
facebook-www/ReactDOM-prod.modern.js = 678.24 kB 678.24 kB = 119.42 kB 119.42 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 450ad4d

@poteto poteto requested a review from Copilot October 7, 2025 18:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds dry run functionality to the compiler release script, enabling testing of the release process without actually publishing packages. This allows for safer validation of release workflows and configurations before executing actual releases.

  • Added dry run support to CI workflows with conditional execution paths
  • Introduced dry_run input parameter to manual and reusable workflow definitions
  • Modified version string generation logic to handle 'latest' tag separately

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
compiler/scripts/release/publish.js Updates version string generation logic to handle 'latest' tag case
.github/workflows/compiler_prereleases_nightly.yml Adds dry_run parameter set to false for nightly releases
.github/workflows/compiler_prereleases_manual.yml Adds dry_run input parameter for manual workflow triggers
.github/workflows/compiler_prereleases.yml Implements conditional dry run execution with separate workflow steps

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

poteto added a commit that referenced this pull request Oct 7, 2025
Script was using the wrong version name.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34764).
* #34765
* __->__ #34764
@poteto poteto requested a review from Copilot October 7, 2025 18:33
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Allow running the compiler release script as dry run.
@poteto poteto merged commit 69b4cb8 into main Oct 7, 2025
240 of 241 checks passed
@poteto poteto deleted the pr34765 branch October 7, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants