Enable suspenseCallback on React Native #29210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: dcae56f8b72f625d8affe5729ca9991b31a492ac...c6df5b778fd308f7eb790d17d8e55cce22d62d59 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
rickhanlonii
requested changes
May 22, 2024
Member
rickhanlonii
left a comment
rickhanlonii
left a comment
There was a problem hiding this comment.
Let's discuss more, I'm not sure if we want to expand usage of this feature until we know for sure it makes sense and has a path to making it to open source.
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
bot
added
the
Resolution: Stale
rickhanlonii
approved these changes
Aug 22, 2024
github-actions
bot
removed
the
Resolution: Stale
bgirard
force-pushed
the
SuspenseCallbackRN
branch
3 times, most recently
from
d341cc7 to
912997e
Compare
poteto
force-pushed
the
SuspenseCallbackRN
branch
from
912997e to
d49c9e6
Compare
bgirard
force-pushed
the
SuspenseCallbackRN
branch
from
d49c9e6 to
7c3f7f2
Compare
poteto
approved these changes
Aug 22, 2024
bgirard
force-pushed
the
SuspenseCallbackRN
branch
from
7c3f7f2 to
cacdd2f
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
## Summary suspenseCallback feature has proved to be useful for FB Web. Let's look at enabling the feature for the React Native build. ## How did you test this change? Will sync the react changes with a React Native build and will verify that performance logging is correctly notified of suspense promises during the suspense callback. DiffTrain build for commit 246d7bf.
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
suspenseCallback feature has proved to be useful for FB Web. Let's look at enabling the feature for the React Native build.
How did you test this change?
Will sync the react changes with a React Native build and will verify that performance logging is correctly notified of suspense promises during the suspense callback.