Skip to content

Commit 7c3f7f2

Browse files
committed
Enable suspenseCallback on React Native
1 parent eb7570b commit 7c3f7f2

File tree

3 files changed

+55
-6
lines changed

3 files changed

+55
-6
lines changed

packages/react-reconciler/src/__tests__/ReactSuspenseCallback-test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ describe('ReactSuspense', () => {
4646

4747
// Warning don't fire in production, so this test passes in prod even if
4848
// the suspenseCallback feature is not enabled
49-
// @gate www || !__DEV__
49+
// @gate enableSuspenseCallback || !__DEV__
5050
it('check type', async () => {
5151
const {PromiseComp} = createThenable();
5252

@@ -71,7 +71,7 @@ describe('ReactSuspense', () => {
7171
await expect(async () => await waitForAll([])).toErrorDev([]);
7272
});
7373

74-
// @gate www
74+
// @gate enableSuspenseCallback
7575
it('1 then 0 suspense callback', async () => {
7676
const {promise, resolve, PromiseComp} = createThenable();
7777

@@ -98,7 +98,7 @@ describe('ReactSuspense', () => {
9898
expect(ops).toEqual([]);
9999
});
100100

101-
// @gate www
101+
// @gate enableSuspenseCallback
102102
it('2 then 1 then 0 suspense callback', async () => {
103103
const {
104104
promise: promise1,
@@ -145,7 +145,7 @@ describe('ReactSuspense', () => {
145145
expect(ops).toEqual([]);
146146
});
147147

148-
// @gate www
148+
// @gate enableSuspenseCallback
149149
it('nested suspense promises are reported only for their tier', async () => {
150150
const {promise, PromiseComp} = createThenable();
151151

@@ -177,7 +177,7 @@ describe('ReactSuspense', () => {
177177
expect(ops2).toEqual([new Set([promise])]);
178178
});
179179

180-
// @gate www
180+
// @gate enableSuspenseCallback
181181
it('competing suspense promises', async () => {
182182
const {
183183
promise: promise1,

packages/shared/forks/ReactFeatureFlags.native-fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export const enableScopeAPI = false;
8080
export const enableServerComponentLogs = true;
8181
export const enableSuspenseAvoidThisFallback = false;
8282
export const enableSuspenseAvoidThisFallbackFizz = false;
83-
export const enableSuspenseCallback = false;
83+
export const enableSuspenseCallback = true;
8484
export const enableTaint = true;
8585
export const enableTransitionTracing = false;
8686
export const enableTrustedTypesIntegration = false;

patch

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
diff --git a/packages/react-reconciler/src/__tests__/ReactSuspenseCallback-test.js b/packages/react-reconciler/src/__tests__/ReactSuspenseCallback-test.js
2+
index eae080d35c..6ddc94905a 100644
3+
--- a/packages/react-reconciler/src/__tests__/ReactSuspenseCallback-test.js
4+
+++ b/packages/react-reconciler/src/__tests__/ReactSuspenseCallback-test.js
5+
@@ -46,7 +46,7 @@ describe('ReactSuspense', () => {
6+
7+
// Warning don't fire in production, so this test passes in prod even if
8+
// the suspenseCallback feature is not enabled
9+
- // @gate www || !__DEV__
10+
+ // @gate enableSuspenseCallback || !__DEV__
11+
it('check type', async () => {
12+
const {PromiseComp} = createThenable();
13+
14+
@@ -71,7 +71,7 @@ describe('ReactSuspense', () => {
15+
await expect(async () => await waitForAll([])).toErrorDev([]);
16+
});
17+
18+
- // @gate www
19+
+ // @gate enableSuspenseCallback
20+
it('1 then 0 suspense callback', async () => {
21+
const {promise, resolve, PromiseComp} = createThenable();
22+
23+
@@ -98,7 +98,7 @@ describe('ReactSuspense', () => {
24+
expect(ops).toEqual([]);
25+
});
26+
27+
- // @gate www
28+
+ // @gate enableSuspenseCallback
29+
it('2 then 1 then 0 suspense callback', async () => {
30+
const {
31+
promise: promise1,
32+
@@ -145,7 +145,7 @@ describe('ReactSuspense', () => {
33+
expect(ops).toEqual([]);
34+
});
35+
36+
- // @gate www
37+
+ // @gate enableSuspenseCallback
38+
it('nested suspense promises are reported only for their tier', async () => {
39+
const {promise, PromiseComp} = createThenable();
40+
41+
@@ -177,7 +177,7 @@ describe('ReactSuspense', () => {
42+
expect(ops2).toEqual([new Set([promise])]);
43+
});
44+
45+
- // @gate www
46+
+ // @gate enableSuspenseCallback
47+
it('competing suspense promises', async () => {
48+
const {
49+
promise: promise1,

0 commit comments

Comments
 (0)