Remove dead pyre-ignore directives
#855
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D57433947 |
|
This pull request was exported from Phabricator. Differential Revision: D57433947 |
stroxler
added a commit
that referenced
this pull request
May 16, 2024
Summary: Pull Request resolved: #855 The dataclasses-json version we are getting in github has types that are incompatible with the internal version. As a result, we need to pin the version on github to get comparable results (in addition it's at least possible we would get bugs in open-source without pinning). I filed T189226004 to bump the version internally. In addition: - we aren't marking `toml` as a dependency, but we need it as a dev dependency because type checking the typeshed patcher requires it - we need to list both tabulate and toml in our .pyre_configuration for github to pick them up because we are still using the legacy setup where packages aren't picked up by default... this would probably be good to change at some point. Differential Revision: D57433947
stroxler
force-pushed
the
export-D57433947
branch
from
757a9c6 to
b847c99
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
May 16, 2024
Summary: The dataclasses-json version we are getting in github has types that are incompatible with the internal version. As a result, we need to pin the version on github to get comparable results (in addition it's at least possible we would get bugs in open-source without pinning). I filed T189226004 to bump the version internally. In addition: - we aren't marking `toml` as a dependency, but we need it as a dev dependency because type checking the typeshed patcher requires it - we need to list both tabulate and toml in our .pyre_configuration for github to pick them up because we are still using the legacy setup where packages aren't picked up by default... this would probably be good to change at some point. Differential Revision: D57433947
facebook-github-bot
pushed a commit
that referenced
this pull request
May 16, 2024
Summary: The dataclasses-json version we are getting in github has types that are incompatible with the internal version. As a result, we need to pin the version on github to get comparable results (in addition it's at least possible we would get bugs in open-source without pinning). I filed T189226004 to bump the version internally. In addition: - we aren't marking `toml` as a dependency, but we need it as a dev dependency because type checking the typeshed patcher requires it - we need to list both tabulate and toml in our .pyre_configuration for github to pick them up because we are still using the legacy setup where packages aren't picked up by default... this would probably be good to change at some point. Differential Revision: D57433947
facebook-github-bot
pushed a commit
that referenced
this pull request
May 16, 2024
Summary: The dataclasses-json version we are getting in github has types that are incompatible with the internal version. As a result, we need to pin the version on github to get comparable results (in addition it's at least possible we would get bugs in open-source without pinning). I filed T189226004 to bump the version internally. In addition: - we aren't marking `toml` as a dependency, but we need it as a dev dependency because type checking the typeshed patcher requires it - we need to list both tabulate and toml in our .pyre_configuration for github to pick them up because we are still using the legacy setup where packages aren't picked up by default... this would probably be good to change at some point. Differential Revision: D57433947
facebook-github-bot
pushed a commit
that referenced
this pull request
May 16, 2024
Summary: The dataclasses-json version we are getting in github has types that are incompatible with the internal version. As a result, we need to pin the version on github to get comparable results (in addition it's at least possible we would get bugs in open-source without pinning). I filed T189226004 to bump the version internally. In addition: - we aren't marking `toml` as a dependency, but we need it as a dev dependency because type checking the typeshed patcher requires it - we need to list both tabulate and toml in our .pyre_configuration for github to pick them up because we are still using the legacy setup where packages aren't picked up by default... this would probably be good to change at some point. Differential Revision: D57433947
facebook-github-bot
pushed a commit
that referenced
this pull request
May 16, 2024
Summary: The dataclasses-json version we are getting in github has types that are incompatible with the internal version. As a result, we need to pin the version on github to get comparable results (in addition it's at least possible we would get bugs in open-source without pinning). I filed T189226004 to bump the version internally. In addition: - we aren't marking `toml` as a dependency, but we need it as a dev dependency because type checking the typeshed patcher requires it - we need to list both tabulate and toml in our .pyre_configuration for github to pick them up because we are still using the legacy setup where packages aren't picked up by default... this would probably be good to change at some point. Differential Revision: D57433947
facebook-github-bot
force-pushed
the
export-D57433947
branch
from
b847c99 to
1bce123
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57433947 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D57433947 |
stroxler
added a commit
that referenced
this pull request
May 16, 2024
Summary: Pull Request resolved: #855 The dataclasses-json version we are getting in github has types that are incompatible with the internal version. As a result, we need to pin the version on github to get comparable results (in addition it's at least possible we would get bugs in open-source without pinning). I filed T189226004 to bump the version internally. In addition: - we aren't marking `toml` as a dependency, but we need it as a dev dependency because type checking the typeshed patcher requires it - we need to list both tabulate and toml in our .pyre_configuration for github to pick them up because we are still using the legacy setup where packages aren't picked up by default... this would probably be good to change at some point. Differential Revision: D57433947
stroxler
force-pushed
the
export-D57433947
branch
from
1bce123 to
512a4a5
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
May 16, 2024
Summary: The dataclasses-json version we are getting in github has types that are incompatible with the internal version. As a result, we need to pin the version on github to get comparable results (in addition it's at least possible we would get bugs in open-source without pinning). I filed T189226004 to bump the version internally. In addition: - we aren't marking `toml` as a dependency, but we need it as a dev dependency because type checking the typeshed patcher requires it - we need to list both tabulate and toml in our .pyre_configuration for github to pick them up because we are still using the legacy setup where packages aren't picked up by default... this would probably be good to change at some point. Differential Revision: D57433947
Summary: Unfortunately we still don't get flake8 errors on unused imports internally, so I introduced a few of these when I was fixing broken unit tests in github CI. This should make the lint signal clean, so that on github only the `pyre` and `pysa` signals will be red (they have been broken for a long time and I don't have a quick fix for them yet, I'll try to tackle them in the next week or two). Differential Revision: D57386423
Differential Revision: D57387918
Summary: Pull Request resolved: #855 The dataclasses-json version we are getting in github has types that are incompatible with the internal version. As a result, we need to pin the version on github to get comparable results (in addition it's at least possible we would get bugs in open-source without pinning). I filed T189226004 to bump the version internally. In addition: - we aren't marking `toml` as a dependency, but we need it as a dev dependency because type checking the typeshed patcher requires it - we need to list both tabulate and toml in our .pyre_configuration for github to pick them up because we are still using the legacy setup where packages aren't picked up by default... this would probably be good to change at some point. Reviewed By: yangdanny97 Differential Revision: D57433947
|
This pull request was exported from Phabricator. Differential Revision: D57433947 |
stroxler
force-pushed
the
export-D57433947
branch
from
512a4a5 to
45a6a4b
Compare
|
This pull request has been merged in 998b5d3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The dataclasses-json version we are getting in github has types that
are incompatible with the internal version. As a result, we need to pin
the version on github to get comparable results (in addition it's at
least possible we would get bugs in open-source without pinning). I
filed T189226004 to bump the version internally.
In addition:
tomlas a dependency, but we need it as a devdependency because type checking the typeshed patcher requires it
for github to pick them up because we are still using the legacy
setup where packages aren't picked up by default... this would
probably be good to change at some point.
Differential Revision: D57433947