Skip to content

Commit 7526b33

Browse files
stroxlerfacebook-github-bot
authored andcommitted
Remove dead pyre-ignore directives (#855)
Summary: The dataclasses-json version we are getting in github has types that are incompatible with the internal version. As a result, we need to pin the version on github to get comparable results (in addition it's at least possible we would get bugs in open-source without pinning). I filed T189226004 to bump the version internally. In addition: - we aren't marking `toml` as a dependency, but we need it as a dev dependency because type checking the typeshed patcher requires it - we need to list both tabulate and toml in our .pyre_configuration for github to pick them up because we are still using the legacy setup where packages aren't picked up by default... this would probably be good to change at some point. Differential Revision: D57433947
1 parent 1ffae5a commit 7526b33

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

tools/typeshed_patcher/typeshed.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ class Typeshed(abc.ABC):
5757
Representation of a collection of Python stub files.
5858
"""
5959

60-
# pyre-fixme[56]: Pyre doesn't yet support decorators with ParamSpec applied to
61-
# generic functions Please add # pyre-ignore[56] to `abc.abstractclassmethod`.
6260
@abc.abstractclassmethod
6361
def get_file_content(self, path: pathlib.Path) -> Optional[str]:
6462
"""
@@ -69,8 +67,6 @@ def get_file_content(self, path: pathlib.Path) -> Optional[str]:
6967
"""
7068
raise NotImplementedError()
7169

72-
# pyre-fixme[56]: Pyre doesn't yet support decorators with ParamSpec applied to
73-
# generic functions Please add # pyre-ignore[56] to `abc.abstractclassmethod`.
7470
@abc.abstractclassmethod
7571
def all_files(self) -> Iterable[pathlib.Path]:
7672
"""

0 commit comments

Comments
 (0)