-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add Mi Band connector #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fabOnReact
wants to merge
1
commit into
main
Choose a base branch
from
codex/install-rn-miband-connector-and-implement-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Mi Band Setup | ||
|
||
To connect a Mi Band device with this library: | ||
|
||
1. Pair the band with your Android phone using the official **Mi Fitness** (or **Zepp Life**) application. | ||
2. Ensure Bluetooth is enabled and the band is connected before launching your React Native app. | ||
3. Grant the application the required permissions: | ||
- `android.permission.BLUETOOTH_CONNECT` | ||
- `android.permission.BLUETOOTH_SCAN` | ||
- `android.permission.ACCESS_FINE_LOCATION` (required for Bluetooth Low Energy scanning on older Android versions) | ||
- `android.permission.BODY_SENSORS` if accessing heart rate or other biometric data | ||
- `android.permission.POST_NOTIFICATIONS` to receive notifications on recent Android versions | ||
|
||
Without pairing through the Mi Fitness application the device will not accept connections from third‑party apps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
import { EventEmitter } from 'events'; | ||
import type { AddListener, WatchEvents } from '../types'; | ||
// The rn-miband-connector library exposes an EventEmitter that | ||
// delivers raw Mi Band events. We translate those events to the | ||
// shared `watchEvents` interface used by this project. | ||
// | ||
// We keep the dependency typed as `any` to avoid requiring its | ||
// TypeScript definitions. | ||
// eslint-disable-next-line @typescript-eslint/no-var-requires | ||
const MiBand: any = require('rn-miband-connector'); | ||
|
||
const miband = new MiBand(); | ||
const emitter = new EventEmitter(); | ||
|
||
// Forward any event from the Mi Band library as a `message` event so | ||
// that consumers can subscribe via `watchEvents.on('message', cb)`. | ||
miband.on('data', (payload: unknown) => { | ||
emitter.emit('message', payload); | ||
}); | ||
|
||
// Some implementations might emit a generic `event` callback instead | ||
// of `data`. Handle that as well. | ||
miband.on('event', (payload: unknown) => { | ||
emitter.emit('message', payload); | ||
}); | ||
|
||
const addListener: AddListener = (event, cb) => { | ||
if (event !== 'message') { | ||
throw new Error(`Unknown watch event "${event}"`); | ||
} | ||
|
||
emitter.on(event, cb); | ||
return () => { | ||
emitter.removeListener(event, cb); | ||
}; | ||
}; | ||
|
||
export const mibandEvents: WatchEvents = { | ||
addListener, | ||
on: addListener, | ||
}; | ||
|
||
export default mibandEvents; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
declare module 'rn-miband-connector'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Export Mi Band connector through public API
The new
MiBandConnector
declares and exportsmibandEvents
, but nothing in the package imports or re‑exports it.watchEvents
insubscriptions.ts
still uses the existing native module, so consumers loadingreact-native-wear-connectivity
cannot subscribe to Mi Band events despite the new README/docs. As written this code is dead and the added dependency brings no usable feature. Consider wiring the connector intowatchEvents
or re-exporting it from the library entry point so callers can actually receive Mi Band data.Useful? React with 👍 / 👎.