Skip to content

Conversation

fabOnReact
Copy link
Owner

Summary

  • add Mi Band connector translating library events to watchEvents
  • document Mi Band pairing requirements and permissions

Testing

  • yarn lint (fails: ESLint couldn't find the plugin "eslint-plugin-ft-flow")
  • yarn typecheck
  • yarn test (fails: Cannot find module '@react-native/babel-preset')

https://chatgpt.com/codex/tasks/task_e_68b70274f8848320a3cca865b567ffb2

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines +38 to +39
export const mibandEvents: WatchEvents = {
addListener,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Export Mi Band connector through public API

The new MiBandConnector declares and exports mibandEvents, but nothing in the package imports or re‑exports it. watchEvents in subscriptions.ts still uses the existing native module, so consumers loading react-native-wear-connectivity cannot subscribe to Mi Band events despite the new README/docs. As written this code is dead and the added dependency brings no usable feature. Consider wiring the connector into watchEvents or re-exporting it from the library entry point so callers can actually receive Mi Band data.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant