Add BlockchainData#createIndexProof [ECR-4176] #1401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
approved these changes
Feb 3, 2020
bullet-tooth
approved these changes
Feb 4, 2020
| Fork fork = db.createFork(cl); | ||
|
|
||
| // Use the full index name | ||
| String fullIndexName = serviceName + "." + simpleIndexName; |
There was a problem hiding this comment.
I found that this code is frequently used. Maybe it's time to consider creating a function somewhere?
There was a problem hiding this comment.
In tests I think it's OK to use it, but where else? The service schemas has been migrated to simple names (they no longer need explicit namespacing since #1393 ).
It might make sense to make it public in the BlockchainData if it is needed in proof creation (but I am not sure it will be needed).
dmitry-timofeev
changed the base branch from
replace-ro-fork-with-erased-ECR-4176
to
numeric-index-ids-for-cache
dmitry-timofeev
force-pushed
the
add-index-proof-to-bd-ECR-4176
branch
from
cb1e35b to
9911b3d
Compare
|
Rebased onto target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add BlockchainData#createIndexProof.
See: https://jira.bf.local/browse/ECR-4176
Definition of Done