Integrate blockchain data [ECR-4175] #1393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip: description
Add Node#withServiceData for symmetry with Testkit and TransactionContext.
Rename to have consistent naming in BD accessors: - Testkit - TransactionContext - Node
BlockchainData#fromRawAccess cannot be invoked with mock tests as it will invoke the native code with an invalid handle. Hence the code that needs to instantiate BD from Access has to use the factory.
dmitry-timofeev
changed the base branch from
master
to
numeric-index-ids-for-cache
[skip ci]
exonum-java-binding/CHANGELOG.md
Outdated
| the service to which it is provided and allows modification only to the data | ||
| of that service. The service data is automatically isolated via namespaces, | ||
| with a service name followed by a dot as a prefix. (#1393) | ||
| - `Prefixed` and `ReadonlyFork` database Accesses. |
| * @param instanceName the name of the service instance to which data to provide access | ||
| * <p>The namespace is equal to the service instance name. | ||
| * | ||
| * @param serviceName the name of the service instance to which data to provide access |
There was a problem hiding this comment.
the sentence looks complicated a little bit.
"service instance name for providing data access to"
There was a problem hiding this comment.
The original seems to be more exact, but I agree it is a little complex, though can't think how to simplify it.
| * Creates a new owning blockchain data. | ||
| * | ||
| * @param nativeHandle a handle to the native BlockchainData object | ||
| * @param cleaner a cleaner to register the destructor\ |
There was a problem hiding this comment.
Suggested change
| * @param cleaner a cleaner to register the destructor\ | |
| * @param cleaner a cleaner to register the destructor |
bullet-tooth
approved these changes
Jan 31, 2020
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added BlockchainData — an object providing access to all categories of persistent data stored in the database: the executing service data, other services’ data, Exonum Core data.
BlockchainData is a service-specific object — it remembers the service to which it is provided and allows modification only to the data of that service. The service data is automatically isolated via namespaces, with a service name followed by a dot as a prefix.
Node is also made a service-specific interface — and now provides BlockchainData.
NodeProxy is no longer a Node, as it works with Snapshots.
Removed AbstractService#createDataSchema — just use the schema constructor/factory method. Also, with BlockchainData and Prefixed access it makes more sense to support injecting TransactionContext components (Jira tbd).
See: https://jira.bf.local/browse/ECR-4175
Definition of Done