-
-
Notifications
You must be signed in to change notification settings - Fork 11
Update to Ruby 3.0.2 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Ruby 3.0.2 #47
Conversation
|
That (the current failure) is strange, because the README from setup-ruby says:
|
|
Don't forget to specify the Ruby version in the Gemfile as well. It might be the reason for the failure(??). |
| ^ | ||
| SYNTAX_ERRORS | ||
| assert_equal expected.strip, actual['message'] | ||
| assert_equal expected, actual['message'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without that, 2 tests fail:
| 1) Failure:
| TestRunnerTest#test_syntax_errors_in_tests [/Users/katrinleinweber/Exercism.io/ruby-test-runner/test/test_runner_test.rb:111]:
| Expected: "Line 3: syntax error, unexpected ',', expecting end-of-input\n,'This is meant to be a syntax...\n^"
| Actual: "Line 3: syntax error, unexpected ',', expecting end-of-input\n,'This is meant to be a syntax...\n^\n"
|
| 2) Failure:
| TestRunnerTest#test_syntax_errors_in_code [/Users/katrinleinweber/Exercism.io/ruby-test-runner/test/test_runner_test.rb:127]:
| Expected: "Line 2: syntax error, unexpected ',', expecting end-of-input\nend,A stray comma\n ^"
| Actual: "Line 2: syntax error, unexpected ',', expecting end-of-input\nend,A stray comma\n ^\n"
|
| 12 runs, 19 assertions, 2 failures, 0 errors, 0 skips
I added an explanation to the description of 7cdb940 ;-)
|
@katrinleinweber Great. Thanks! I'll release a proper mandate version too. You ok to try and get the rubocop thing fixed or want me to look at it? |
1ec5c50 to
14d623c
Compare
I though a62c037 would do that, but I forgot he second occurrence m-( Fixed now & force-pushed. @kotp Edit: Whoa! That somehow included earlier commits & closed the PR. Sorry about that! I think I confused GitHub with a shallow clone of my fork, and a @iHiD: Could you please reopen? It should be all cleaned up now. |
Either json 2.6.1 or File.write seems to append an additional \n at the end of the parsed results.json. Thus, both assertion argument need to be treated the same now.
14d623c to
c36802a
Compare
|
I can't reopen - it won't let me. Have you deleted the branch maybe? |
|
Thank you, @Steffan153 :-) @iHiD I'm fine with either option (☝️ or a new PR). I didn't delete Both branches now include @kotp's suggestion to also set |
|
Could you put another PR up then pls :) |
|
Sure thing: #48 :-) |
Thanks to @iHiD's advice in #41, I think this resolves #40 in a more complete way:
docker build .succeedsbundle exec rake testas well:12 runs, 21 assertions, 0 failures, 0 errors, 0 skipsThis PR also bumps gems to newer versions:
mandate, as advisedjson, to resolveArgumentError: wrong number of arguments (given 2, expected 1)inTestRunnerTest#…parser, to stopwarning: parser/current is loading parser/ruby27, which recognizes 2.7.x-compliant syntax, but you are running 3.0.2.Additionally, a blanket
bundle updatecould also be added here.