-
-
Notifications
You must be signed in to change notification settings - Fork 11
Use Ruby 3 #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Ruby 3 #41
Conversation
ErikSchierboom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Ruby 3 now the minimum version, or is it backwards compatible?
|
It's pretty backwards compatible. Code that raised deprecation warnings in Ruby 2.7 will now result in ArgumentError or different behaviour, but this is mainly around where kwargs and the final args being hashes could be confusing. As Ruby 3.0 is now "normal" in production, I think we should probably make the upgrade. |
|
:+1 |
|
When is this going to be merged? :) |
|
The test runner codebase isn't actually compatible with Ruby 3 so that needs fixing first, then it'll get merged :) |
|
We could mark this as draft until the prerequisite is done. That will prevent it from coming in early. |
@iHiD: Are there specific lines that need to be changed? I tried relying on RubyMine's default inspections & "problem" detection just now, but found none. I'd be interested in taking a stab at this task, but I'd need a few pointers and help to get started. Specifically, I'm encountering this after following the README's instructions:
for all TestRunnerTest#… tests, and for AttacksTest#test_large_output_is_truncated. The folders are being created just fine, the |
|
@katrinleinweber Hi there :) Thanks for picking this up. Try uncommenting one of https://github.com/exercism/ruby-test-runner/blob/main/test/test_helper.rb#L61 and commenting out the ones below. You should get better info then. This is a weird project as it's effectively wrapping minitest in an external runner, and capturing stdout/stderr, so getting logging out can be tricky. But that should help. I think the issue might have been that Mandate wasn't compatible with Ruby 3, but try using Happy to answer questions and I can take a look at things if there's anything specific that needs another pair of eyes. |
|
Closing in favour of #47 |
Closes #40