Skip to content

Replace assertIs assertion with assertEqual for string literals in tests #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Replace assertIs assertion with assertEqual for string literals in tests #3168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exercises/practice/perfect-numbers/.meta/template.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
self.assertEqual(type(err.exception), ValueError)
self.assertEqual(err.exception.args[0], "{{ case["expected"]["error"] }}")
{% else %}
self.assertIs(
self.assertEqual(
{{ case["property"] | to_snake }}({{input["number"]}}),
"{{ case["expected"] }}"
)
Expand Down
22 changes: 11 additions & 11 deletions exercises/practice/perfect-numbers/perfect_numbers_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,41 +9,41 @@

class PerfectNumbersTest(unittest.TestCase):
def test_smallest_perfect_number_is_classified_correctly(self):
self.assertIs(classify(6), "perfect")
self.assertEqual(classify(6), "perfect")

def test_medium_perfect_number_is_classified_correctly(self):
self.assertIs(classify(28), "perfect")
self.assertEqual(classify(28), "perfect")

def test_large_perfect_number_is_classified_correctly(self):
self.assertIs(classify(33550336), "perfect")
self.assertEqual(classify(33550336), "perfect")


class AbundantNumbersTest(unittest.TestCase):
def test_smallest_abundant_number_is_classified_correctly(self):
self.assertIs(classify(12), "abundant")
self.assertEqual(classify(12), "abundant")

def test_medium_abundant_number_is_classified_correctly(self):
self.assertIs(classify(30), "abundant")
self.assertEqual(classify(30), "abundant")

def test_large_abundant_number_is_classified_correctly(self):
self.assertIs(classify(33550335), "abundant")
self.assertEqual(classify(33550335), "abundant")


class DeficientNumbersTest(unittest.TestCase):
def test_smallest_prime_deficient_number_is_classified_correctly(self):
self.assertIs(classify(2), "deficient")
self.assertEqual(classify(2), "deficient")

def test_smallest_non_prime_deficient_number_is_classified_correctly(self):
self.assertIs(classify(4), "deficient")
self.assertEqual(classify(4), "deficient")

def test_medium_deficient_number_is_classified_correctly(self):
self.assertIs(classify(32), "deficient")
self.assertEqual(classify(32), "deficient")

def test_large_deficient_number_is_classified_correctly(self):
self.assertIs(classify(33550337), "deficient")
self.assertEqual(classify(33550337), "deficient")

def test_edge_case_no_factors_other_than_itself_is_classified_correctly(self):
self.assertIs(classify(1), "deficient")
self.assertEqual(classify(1), "deficient")


class InvalidInputsTest(unittest.TestCase):
Expand Down