Skip to content

Replace assertIs assertion with assertEqual for string literals in tests #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aleksandr-shtaub
Copy link
Contributor

@github-actions

This comment was marked as resolved.

@BethanyG
Copy link
Member

BethanyG commented Sep 1, 2022

Hi @aleksandr-shtaub 👋🏽

Thanks for taking the time to submit a PR! Unfortunately, these changes have been made in the wrong place.

We use a test generator to automatically produce practice exercise test files. They're not intended to be edited directly.
To make the change, you will need to edit the jinja2 template for this exercise and then regenerate the test file by running the generator. You'll need to have both a clone of the Python repo and the problem-specifications repo. From python/ on your cloned Python repo:

./bin/generate_tests.py perfect-numbers

Both the jinja2 template and the re-generated file should then be checked in to the PR.

Let me know if you have any questions.

@BethanyG BethanyG added the do not merge 🚧 Don't merge until this label is removed. label Sep 1, 2022
@aleksandr-shtaub aleksandr-shtaub force-pushed the fix-assertion-in-perfect-numbers-test branch from 90de988 to 752b833 Compare September 1, 2022 20:33
@aleksandr-shtaub
Copy link
Contributor Author

Hi @BethanyG,

Interesting, thank you for the info!
I did a fixup commit.

@BethanyG BethanyG removed the do not merge 🚧 Don't merge until this label is removed. label Sep 1, 2022
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Many thanks! 🌟

@BethanyG BethanyG merged commit d5a4dd9 into exercism:main Sep 1, 2022
@aleksandr-shtaub aleksandr-shtaub deleted the fix-assertion-in-perfect-numbers-test branch September 1, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants