Skip to content

Conversation

@cxw42
Copy link
Contributor

@cxw42 cxw42 commented Oct 5, 2019

While working on exercism/perl5#328, I noticed that the description of robot-name mixed singular and plural. This PR changes robot-name/description.md to use singular forms consistently throughout. I also changed "boot up" to "turn on" in hopes of making it easier for non-native English speakers to understand the text.

This is my first contribution to this project - thank you for considering this PR!

Use singular forms consistently throughout robot-name/description.md
Copy link
Contributor

@yawpitch yawpitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably most native English speakers would have no trouble using the original form -- the implication is that all robots (plural) end up with their own (singular) name assignment -- however I can see how this copy change would improve readability for people without English esoteric knowledge, so I approve.

@yawpitch yawpitch merged commit 94f57e9 into exercism:master Oct 6, 2019
@yawpitch
Copy link
Contributor

yawpitch commented Oct 6, 2019

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants