-
-
Notifications
You must be signed in to change notification settings - Fork 56
Convert robot-name to use generator (#249) #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for doing this! We should have a cpanfile in this exercise directory so the user gets it with the exercise. I'd suggest copying the one that |
|
re: the configlet, it looks like there aren't any changes to the readme for this exercise so don't worry about it. I've not used cygwin myself so sadly I'm not too sure what to suggest to get it working. The configlet comes from https://github.com/exercism/configlet if you want to take a look but I don't think there are any major readme changes at the moment. |
|
Re. the README - Thanks! I can probably run it under Strawberry if necessary in the future. I cleaned up some whitespace by hand. While cleaning, I noticed that the README says:
The existing version of |
db72a5a to
bbd4224
Compare
|
It'd be nice to have, but I'd also be happy to address that in a separate PR with improvements to the test to better check no duplicates can happen. The perl6 implementation goes through every possible name so it could be worth looking there for ideas: https://github.com/exercism/perl6/tree/master/exercises/robot-name |
|
For the readme, it'd probably be better to leave it as is. The readme is generated with a combination of |
I submitted a PR to the problem-specifications repo for the readme changes. Thanks for the tip! Edit Commit d283041 puts the README back the way it was.
I agree with the idea of a separate PR. I think that would make the commit history easier to follow. Edit 9cb26db is rebased on |
This is my first try at one of these, so please let me know what changes I may need to make! I tested it with
and it passes all tests. I used the
bobandpig-latinconversions as examples.I added a perlmaven link to the stub in case students need help getting started with Moo. I am not affiliated with Gabor in any way, but I have found his resources useful in the past. I am happy to change that if you have a better link.
Thank you for considering this PR!
-Chris (CXW)
Edit I should also add that I am working in cygwin and couldn't get configlet to work. Therefore, I have not updated the README. Please let me know if that is essential, and I'll see what I can hack.