Skip to content

Conversation

@andrerfcsantos
Copy link
Member

@andrerfcsantos andrerfcsantos commented Nov 10, 2021

PR made by running:

gomod-sync.exe update --exercises "..\exercises" --goversion 1.16

See #1954

This must be merged only after exercism/go-test-runner#57

@github-actions
Copy link
Contributor

Dear andrerfcsantos

Thank you for contributing to the Go track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@andrerfcsantos andrerfcsantos mentioned this pull request Nov 10, 2021
5 tasks
@andrerfcsantos andrerfcsantos marked this pull request as ready for review November 13, 2021 16:38
@andrerfcsantos andrerfcsantos added the x:size/small Small amount of work label Nov 13, 2021
@junedev
Copy link
Member

junedev commented Nov 13, 2021

In case someone else is looking for this info: The go version in the go.mod file only affects vendoring (which we don't use) and the use of new language features. You can have go 1.13 installed locally and run a program with a go.mod file that specifies go 1.16 without any problems as long as you don't use any language features that are not available in go 1.13.
https://golang.org/ref/mod#go-mod-file-go

@andrerfcsantos andrerfcsantos force-pushed the update-exercises-to-1.16 branch 11 times, most recently from 9cd567d to bf2bf5b Compare November 13, 2021 20:36
@andrerfcsantos andrerfcsantos force-pushed the update-exercises-to-1.16 branch from bf2bf5b to a56deb7 Compare November 13, 2021 21:30
@junedev
Copy link
Member

junedev commented Nov 13, 2021

LGTM, feel free to merge

@andrerfcsantos andrerfcsantos merged commit d8d2082 into exercism:main Nov 13, 2021
@junedev
Copy link
Member

junedev commented Nov 13, 2021

@andrerfcsantos Feel free to change the size label to "medium" here. I feel with all the debugging it was more work than "small".

@andrerfcsantos andrerfcsantos deleted the update-exercises-to-1.16 branch November 13, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:size/small Small amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants