-
-
Couldn't load subscription status.
- Fork 671
Add gomod-sync #1954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gomod-sync #1954
Conversation
Dear andrerfcsantosThank you for contributing to the Go track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
9e0d88d to
c1b8564
Compare
aef77e6 to
1ca7f2a
Compare
6a8a940 to
11efb05
Compare
|
Ready for review 🚀 This one is on the bigger side, so feel free to take your time, there is no rush. This is what the output of the check looks like when it fails: https://github.com/exercism/go/runs/4662874598?check_suite_focus=true For the output in case everything is fine, see the |
This comment has been minimized.
This comment has been minimized.
9c66dd0 to
0079e44
Compare
This comment has been minimized.
This comment has been minimized.
0079e44 to
5fff775
Compare
5fff775 to
1cd473b
Compare
This comment has been minimized.
This comment has been minimized.
1cd473b to
f7c1bc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to do a review. I don't know anything about cobra though so I can't comment on that. The part that I could understand looked good to me, just some minor comments.
31c927e to
b5c120a
Compare
|
@junedev Thanks! Applied all the changes. Left comments in the conversations, feel free to un-resolve any of them or suggest further changes if there's something that can be further improved. |
b5c120a to
e42cce7
Compare
|
@andrerfcsantos Thanks for addressing all the comments. Feel free to merge whenever you like. (I don't think there will be more reviews if we wait longer tbh.) |
Part of #1881
This PR introduces a new tool to the repo:
gomod-sync. This is a little program to:go.modfiles and the Go versions they are declaring via thegomod-sync listcommand.go.modfiles from the exercises are set to a specific version, with thegomod-sync checkcommand. The desired version can be set with the--goversionflag.go.modfiles to a specific version with thegomod-sync updatecommand. The desired version for the update can be set with the--goversionflag.Right now these 3 commands are working. The
updatecommand was ran against the repo to update all exercises to 1.16, and the result is #1955Tasks
list,checkandupdatecommandscheckcommand in CI