Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in the implementation of
assert_(no_)call. For example,called_fn module: Enum, name: :mapis going to match the usage of any function namedmap, even if it has nothing to do with theEnummodule. My expectation is that it would only match calls toEnum.map, and allow using any othermapfunctions even if somebody tries to cheat by aliasing or importingEnum. I would expect that to detect that, we would write a separate check that forbids aliases and imports of that module.This bug also causes the usage of an underscore
_, e.g. in[h | _] = listto trigger checks forcalled_fn module: Enum, name: :_.@neenjaw is this something you could look into, since you're already familiar with that code? I'm creating this PR with failing tests, feel free to use it and push commits here.