Analyze bird-count #50
Conversation
lib/test_suite/bird_count.ex
Outdated
| Enum.map(not_allowed_functions, fn {module, function} -> | ||
| assert_no_call "does not call #{module}.#{function}" do | ||
| type :essential | ||
| called_fn module: module, name: function | ||
| comment Constants.bird_count_use_recursion() | ||
| end | ||
| end) |
There was a problem hiding this comment.
@neenjaw I'm unable to get this to work. I'm getting this error:
$ mix test test/elixir_analyzer/test_suite/bird_count_test.exs
Compiling 1 file (.ex)
== Compilation error in file lib/test_suite/bird_count.ex ==
** (ArgumentError) calling function signature requires :module to be nil or a module atom, got: {:module, [line: 20], nil}
lib/elixir_analyzer/exercise_test/assert_call.ex:121: ElixirAnalyzer.ExerciseTest.AssertCall.validate_module/1
lib/elixir_analyzer/exercise_test/assert_call.ex:105: ElixirAnalyzer.ExerciseTest.AssertCall.validate_signature/1
lib/elixir_analyzer/exercise_test/assert_call.ex:67: ElixirAnalyzer.ExerciseTest.AssertCall.do_walk_assert_call_block/2
(elixir 1.11.3) lib/macro.ex:482: anonymous fn/4 in Macro.do_traverse_args/4
(elixir 1.11.3) lib/enum.ex:1533: Enum."-map_reduce/3-lists^mapfoldl/2-0-"/3
(elixir 1.11.3) lib/enum.ex:1533: Enum."-map_reduce/3-lists^mapfoldl/2-0-"/3
(elixir 1.11.3) lib/macro.ex:448: Macro.do_traverse/4
lib/elixir_analyzer/exercise_test/assert_call.ex:57: ElixirAnalyzer.ExerciseTest.AssertCall.walk_assert_call_block/2
I'm sure it's something obvious and I'm probably attempting to use macros incorrectly. I tried various combinations of quote/unquote and I just don't get it (I'm having a bad day probably...) Could you advise? How do I achieve what I need? (Dynamically pass all Enum, List, and Stream functions to assert_no_call)
There was a problem hiding this comment.
I arrived at this monster that uses Code.eval_quoted: 77ced7a (#50)
|
I'm marking this as ready for review because it works, but I expect some code quality improvement might be necessary before a merge. It feels very dirty to use |
|
#51 <- should make this cleaner, being able to specify function name wildcards. |
|
I merged #51, you're good to rebase to make use of the changes |
lib/test_suite/bird_count.ex
Outdated
| assert_no_call "does not call any Enum functions" do | ||
| type :essential | ||
| called_fn module: Enum, name: :_ | ||
| comment Constants.bird_count_use_recursion() |
There was a problem hiding this comment.
@neenjaw This doesn't work. I get the error about comment missing because it's:
[{{:., [line: 13], [{:__aliases__, [line: 13], [:Constants]}, :bird_count_use_recursion]}, [line: 13], []}]
And not a binary, so it doesn't get added (fails the guard when is_binary(comment) in do_walk_assert_call_block).
|
I merged your |
|
I think this is good to go. Merged in main to get the latest changes. I'm going to merge it so that all of the changes are present for the other PRs |
The
bird-countexercise is supposed to teach recursion and should be solved using recursion-only.A corresponding website-copy PR: exercism/website-copy#1960