fix AsyncEventFilterBuilder looking for Web3 instead of AsyncWeb3 #2934
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
fix-async-filter-isinstance-bug
branch
from
6c03765 to
1310bca
Compare
pacrob
force-pushed
the
fix-async-filter-isinstance-bug
branch
from
1310bca to
624a6cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The
AsyncEventFilterBuilderclass was validating forWeb3instead ofAsyncWeb3. Tests were passing because theasync_w3fixture was alsoWeb3.Closes #2931
How was it fixed?
Changed
Web3toAsyncWeb3where needed.Todo:
Cute Animal Picture