Skip to content

Commit 1310bca

Browse files
committed
fix AsyncEventFilterBuilder bug - was looking for Web3 instead of AsyncWeb3
1 parent 09baffc commit 1310bca

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

newsfragments/2931.bugfix.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
fix AsyncEventFilterBuilder looking for Web3 instead of AsyncWeb3

tests/core/filtering/utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from web3 import (
2+
AsyncWeb3,
23
Web3,
34
)
45
from web3.eth import (
@@ -48,7 +49,7 @@ def _emitter_fixture_logic(
4849
def _async_w3_fixture_logic(request):
4950
use_filter_middleware = request.param
5051
provider = AsyncEthereumTesterProvider()
51-
async_w3 = Web3(provider, modules={"eth": [AsyncEth]}, middlewares=[])
52+
async_w3 = AsyncWeb3(provider, modules={"eth": [AsyncEth]}, middlewares=[])
5253

5354
if use_filter_middleware:
5455
async_w3.middleware_onion.add(async_local_filter_middleware)

web3/_utils/events.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -447,8 +447,8 @@ def deploy(self, w3: "Web3") -> "LogFilter":
447447

448448
class AsyncEventFilterBuilder(BaseEventFilterBuilder):
449449
async def deploy(self, async_w3: "AsyncWeb3") -> "AsyncLogFilter":
450-
if not isinstance(async_w3, web3.Web3):
451-
raise ValueError(f"Invalid web3 argument: got: {async_w3!r}")
450+
if not isinstance(async_w3, web3.AsyncWeb3):
451+
raise ValueError(f"Invalid async_web3 argument: got: {async_w3!r}")
452452

453453
for arg in AttributeDict.values(self.args):
454454
arg._immutable = True

0 commit comments

Comments
 (0)