Skip to content

[v5] fix: add chainId to txn params (#2450) #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented May 2, 2022

  • fix: add chainId to txn params

  • fix: error message on chain id hex to int

  • Add newsfragment

Co-authored-by: kclowes [email protected]

What was wrong?

There were some stray chain id calls.

See #2450

How was it fixed?

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

* fix: add chainId to txn params

* fix: error message on chain id hex to int

* Add newsfragment

Co-authored-by: kclowes <[email protected]>
@kclowes kclowes merged commit 7942a4a into ethereum:v5 May 2, 2022
@kclowes kclowes deleted the chain-id-tx-params branch May 2, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants