fix: add chainId to txn params #2450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Apr 29, 2022
|
Nice catch! I don't think there is a way to indicate that it's optional, but I don't think we do any checks on it. Lmk if you want help debugging the tests. It looks like they're failing because a hex-to-int conversion isn't happening for the error message in the validation middleware. |
3 tasks
antazoey
force-pushed
the
fix/jules-add-chain-id-to-txn-params
branch
from
c7e537c to
e55aa98
Compare
I believe I got it! |
kclowes
added a commit
to kclowes/web3.py
that referenced
this pull request
May 2, 2022
* fix: add chainId to txn params * fix: error message on chain id hex to int * Add newsfragment Co-authored-by: kclowes <[email protected]>
1 task
kclowes
added a commit
that referenced
this pull request
May 2, 2022
* fix: add chainId to txn params * fix: error message on chain id hex to int * Add newsfragment Co-authored-by: kclowes <[email protected]> Co-authored-by: Juliya Smith <[email protected]>
pacrob
pushed a commit
that referenced
this pull request
May 23, 2022
* fix: add chainId to txn params * fix: error message on chain id hex to int * Add newsfragment Co-authored-by: kclowes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
I noticed even when caching
chain_id, the request occurs multiple times. I figured out this happens because I am callingestimate_gas()and passing it a transaction and the RPC method's defined txn schema does not incluechainIdso it makes the request againt to add the chainId at some point (this is only deduced).. By addingchainIdto the params, I can avoid an extra RPC call to get the chain ID`How was it fixed?
Add
'chainId': 'uint',inTRANSACTION_PARAMS_ABIS.Todo:
Cute Animal Picture