change pypiwin32 to pywin32 #1930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
There is already a web3 recipe on conda-forge, managed by me. https://github.com/conda-forge/web3-feedstock I just some time ago already told it to just use pywin32, as pypiwin32 is anyway only a link to that. You are welcome to contribute of course. |
|
Ah, awesome @step21 . Don't know how I missed that |
Contributor
|
It happens to the best :) Anyway, please open issues if you find any. :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
pypiwin32 is outdated. pywin32 is newer and can be found on conda-forge. We'll probably want to update pywin32, as 223 is not the most recent, but can save that for a different PR.
Closes #1742, #1721, #1892
How was it fixed?
I finally got around to adding a CI smoke test for windows, which was a blocker for merging the initial PR.
The initial commit was really outdated, so I just cherry-picked the commit and put it on top of the most recent master. Retained initial commit authorship - thanks @step21!
Todo:
Cute Animal Picture