Changed pypiwin32 to pywin32 #1742
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge update from upstream
Collaborator
|
Thank you @step21! It looks like 228 is the most recent version of pywin32, so I think we might as well use that unless things break? And I'll double check in the next few days, but will you confirm that web3 installs correctly on your windows machine in a fresh environment with this change? |
Contributor
Author
|
I didn't test if things break, but if you did not require a higher version until now, leaving the older one keeps compatibility so I would just leave it. Web3 def installs and imports correctly. However I cannot run the whole test suite atm (but not because of this change) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
pypiwin32 is just an empty package requiring pywin32, so this can just be required directly. As far as I know, pypiwin32 is only there for historical reasons.
Related to Issue #1721
How was it fixed?
change it in setup.py
Todo:
Cute Animal Picture