feat: optimize apply_abi_formatters_to_dict #3671
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobTheBuidler
commented
Apr 17, 2025
| formatted_dict = dict(zip(fields, formatted_values)) | ||
| return dict(data, **formatted_dict) | ||
| formatted_dict = data.copy() | ||
| formatted_dict.update(zip(fields, formatted_values)) |
Contributor
Author
There was a problem hiding this comment.
Instead of fully initializing a formatted_dict and then initializing a second new dict with it, we can just init one copy of the original dict and update it from a zip
BobTheBuidler
force-pushed
the
formatters
branch
from
56c895d to
b189b01
Compare
Contributor
Author
BobTheBuidler
commented
Apr 19, 2025
| [abi_dict[field] for field in fields], | ||
| [data[field] for field in fields], | ||
| (abi_dict[field] for field in fields), | ||
| (data[field] for field in fields), |
Contributor
Author
There was a problem hiding this comment.
2 less list creations per call
pacrob
approved these changes
Apr 21, 2025
Contributor
pacrob
left a comment
pacrob
left a comment
There was a problem hiding this comment.
Looks good, thanks @BobTheBuidler!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
nothing was wrong, but apply_abi_formatters_to_dict is used frequently so was suitable for optimization
Related to Issue #N/A
Closes #N/A
Todo:
Cute Animal Picture