Skip to content

Limit hypothesis integers in contract data and topic tests to a max value of MAX_UINT_256 #3666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2025
Merged

Limit hypothesis integers in contract data and topic tests to a max value of MAX_UINT_256 #3666

merged 2 commits into from
Apr 18, 2025

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Apr 17, 2025 •
edited
Loading

What was wrong?

Tests on v6 were failing due to a hypothesis upgrade.

How was it fixed?

Added a max_value for hypothesis integers in filtering tests.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes requested review from Copilot, pacrob and reedsa April 17, 2025 17:53
Copilot
Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • newsfragments/3666.internal.rst: Language not supported

@kclowes kclowes requested a review from fselmo April 17, 2025 17:53
pacrob
pacrob approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

fselmo
fselmo approved these changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼

@kclowes kclowes merged commit f2fc30f into ethereum:v6 Apr 18, 2025
118 checks passed
@kclowes kclowes deleted the v6-hypothesis-fails branch April 18, 2025 15:02
This was referenced Apr 18, 2025
Merged
Merged
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@reedsa reedsa reedsa approved these changes

@fselmo fselmo fselmo approved these changes

@pacrob pacrob pacrob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kclowes @reedsa @fselmo @pacrob