Skip to content

Address Hypothesis test fails #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2025
Merged

Address Hypothesis test fails #3665

merged 2 commits into from
Apr 18, 2025

Conversation

@kclowes
Copy link
Collaborator

@kclowes kclowes commented Apr 17, 2025 •
edited
Loading

What was wrong?

Tests on main were failing due to a hypothesis upgrade.

How was it fixed?

Added a max_value for hypothesis integers in filtering tests.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes changed the title Upper pin hypothesis Address Hypothesis test fails Apr 17, 2025
@kclowes kclowes marked this pull request as ready for review April 17, 2025 17:39
@kclowes kclowes force-pushed the failing-test-fixes branch from d6fa976 to 924d90f Compare April 17, 2025 17:45
@kclowes kclowes requested a review from Copilot April 17, 2025 17:53
Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@kclowes kclowes requested review from fselmo, pacrob and reedsa April 17, 2025 17:57
pacrob
pacrob approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@kclowes kclowes merged commit 8a2f478 into ethereum:main Apr 18, 2025
85 checks passed
@kclowes kclowes deleted the failing-test-fixes branch April 18, 2025 15:03
This was referenced Apr 18, 2025
Merged
Merged
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@fselmo fselmo fselmo approved these changes

+2 more reviewers

@reedsa reedsa reedsa approved these changes

@pacrob pacrob pacrob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kclowes @reedsa @fselmo @pacrob