Migrate MarkdownTable to Chakra #8061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImMiguelP
requested review from
corwintines,
jmcook1186,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
pettinarip
requested changes
Sep 28, 2022
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
Hey @ImMiguelP look at this pic
This is the nft page, https://ethereumorgwebsitedev01-immiguelpethereumorgwebsi26645.gtsb.io/en/nft
It seems that the table is wider than the container.
wackerow
approved these changes
Sep 29, 2022
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
@ImMiguelP Nicely done! Yeah, using the Box without the Th looks like the approach to go here; seems to fix it:
Thanks!
pettinarip
approved these changes
Sep 30, 2022
Member
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
Awesome @ImMiguelP LGTM! 💪🏼
80 tasks
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates
MarkdownTablecomponent fromemotiontochakra-uiRelated Issue
#6374