Skip to content

Conversation

@wackerow
Copy link
Member

Description

Breakdown of fields on the block page using codeblocks causing them to be a bit difficult to read.

  • Refactors lists contained within codeblocks into markdown tables.

Currently:
image

Suggested in PR:
image

Not yet in this PR, but if we adjust the styling in MarkdownTable.tsx we can add a little better padding between these columns. The following css would add 0.5rem spacing:

  th:not(:last-of-type), td:not(:last-of-type) {
    padding-inline-end: 0.5rem;
  }

...would result in...
image

@nloureiro Without objection I could add this in. This component will still need to be migrated to Chakra, but shouldn't prevent us from fixing the tight k

Related Issue

None filed

@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 29, 2022

✅ ethereum-org-website-dev deploy preview ready

@nloureiro
Copy link
Contributor

Description

Breakdown of fields on the block page using codeblocks causing them to be a bit difficult to read.

  • Refactors lists contained within codeblocks into markdown tables.

Currently: image

Suggested in PR: image

Not yet in this PR, but if we adjust the styling in MarkdownTable.tsx we can add a little better padding between these columns. The following css would add 0.5rem spacing:

  th:not(:last-of-type), td:not(:last-of-type) {
    padding-inline-end: 0.5rem;
  }

...would result in... image

@nloureiro Without objection I could add this in. This component will still need to be migrated to Chakra, but shouldn't prevent us from fixing the tight k

Related Issue

None filed

I'm ok with this. I will need to re-visit this on the design system side. for now, go for it

@wackerow
Copy link
Member Author

Actually, noting that #8061 fixes this issue by migrating the MarkdownTable.tsx component to Chakra (which has a small amount of spacing between the cells). Going to leave it as is here, should resolve on its own.

@corwintines
Copy link
Member

Merged dev in since #8061 has been merged in.

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@corwintines corwintines merged commit dc06b5c into dev Oct 27, 2022
@corwintines corwintines deleted the block-tables branch October 27, 2022 20:04
@corwintines corwintines mentioned this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content 🖋️ This involves copy additions or edits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants